Add input_shape metric to jagged_sum operator #2313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add new metric to `jagged_sum` that denotes the 0th and 2nd input dimensions, `B` and `M`, in the form `(B, '*', M)`, where the nested tensor has logical dimensions `(B, *, M)`. Display this metric once per `x` value using the `x_only = True` argument to `register_metric()`. This diff will make TritonBench's benchmark table more readable by denoting the nested tensor dimensions used per benchmark row. Reviewed By: jbschlosser Differential Revision: D58535619
|
This pull request was exported from Phabricator. Differential Revision: D58535619 |
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
jananisriram
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
This pull request has been merged in 5f6633d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add new metric to
jagged_sumthat denotes the 0th and 2nd input dimensions,BandM, in the form(B, '*', M), where the nested tensor has logical dimensions(B, *, M). Display this metric once perxvalue using thex_only = Trueargument toregister_metric(). This diff will make TritonBench's benchmark table more readable by denoting the nested tensor dimensions used per benchmark row.Reviewed By: jbschlosser
Differential Revision: D58535619