Refactor code for sum Triton kernels #2303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Extend support for reducing across individual dimensions on 2-dimensional matrices by allowing for varying block sizes on both the `M` (first) and `N` (second) dimensions. The existing kernel performed a simplified reduction, assuming that the entire reduction dimension fit within one thread block. The new kernel implementation removes the need for this assumption, allowing both the reduction and the non-reduction dimensions to fit in multiple thread blocks. This implementation also enables autotuning on block sizes for both the `M` and `N` dimensions. For 1D results, add a `sum_then_add` configuration which decides which kernel configuration to run. `Sum_then_add` sums individual blocks of input and adds these sums into a buffer. `Add_then_sum` adds blocks of raw input into a buffer, reducing the buffer last. Differential Revision: D58313958 Reviewed By: davidberard98
Summary: Refactor code to improve readability and logical flow for cases which select the `sum` Triton kernel implementation to run. Create helper functions for the following cases: - Reduce N-dimensional input to scalar output - Reduce 2-dimensional input to 1-dimensional output - Reduce 3-dimensional input along dimension 1 to 2-dimensional output Add command line argument parsing for the `input_dim` parameter, which specifies the number of dimensions desired in kernel inputs. Modify absolute tolerance to account for floating-point operation error. Reviewed By: jbschlosser Differential Revision: D58488137
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
This pull request was exported from Phabricator. Differential Revision: D58488137 |
|
This pull request has been merged in 339ccfd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor code to improve readability and logical flow for cases which select the
sumTriton kernel implementation to run. Create helper functions for the following cases:Add command line argument parsing for the
input_dimparameter, which specifies the number of dimensions desired in kernel inputs.Modify absolute tolerance to account for floating-point operation error.
Reviewed By: jbschlosser
Differential Revision: D58488137