Extend support to varying block sizes on both dimensions for 2D matrices #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58313958 |
|
This pull request was exported from Phabricator. Differential Revision: D58313958 |
e6567d8
to
017723b
Compare
jananisriram
added a commit
to jananisriram/benchmark
that referenced
this pull request
Jun 14, 2024
…ces (pytorch#2302) Summary: Pull Request resolved: pytorch#2302 Extend support for reducing across individual dimensions on 2-dimensional matrices by allowing for varying block sizes on both the `M` (first) and `N` (second) dimensions. The existing kernel performed a simplified reduction, assuming that the entire reduction dimension fit within one thread block. The new kernel implementation removes the need for this assumption, allowing both the reduction and the non-reduction dimensions to fit in multiple thread blocks. This implementation also enables autotuning on block sizes for both the `M` and `N` dimensions. For 1D results, add a `sum_then_buffer` configuration which decides which kernel configuration to run. `Sum_then_buffer` sums individual blocks of input and adds these sums into a buffer. `Buffer_then_sum` adds blocks of raw input into a buffer, then reduces the buffer. Reviewed By: davidberard98 Differential Revision: D58313958
…ces (pytorch#2302) Summary: Pull Request resolved: pytorch#2302 Extend support for reducing across individual dimensions on 2-dimensional matrices by allowing for varying block sizes on both the `M` (first) and `N` (second) dimensions. The existing kernel performed a simplified reduction, assuming that the entire reduction dimension fit within one thread block. The new kernel implementation removes the need for this assumption, allowing both the reduction and the non-reduction dimensions to fit in multiple thread blocks. This implementation also enables autotuning on block sizes for both the `M` and `N` dimensions. For 1D results, add a `sum_then_buffer` configuration which decides which kernel configuration to run. `Sum_then_buffer` sums individual blocks of input and adds these sums into a buffer. `Buffer_then_sum` adds blocks of raw input into a buffer, then reduces the buffer. Reviewed By: davidberard98 Differential Revision: D58313958
|
This pull request was exported from Phabricator. Differential Revision: D58313958 |
017723b
to
ae0ed4b
Compare
|
This pull request has been merged in f4cbf78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Extend support for reducing across individual dimensions on 2-dimensional matrices by allowing for varying block sizes on both the
M(first) andN(second) dimensions.The existing kernel performed a simplified reduction, assuming that the entire reduction dimension fit within one thread block. The new kernel implementation removes the need for this assumption, allowing both the reduction and the non-reduction dimensions to fit in multiple thread blocks. This implementation also enables autotuning on block sizes for both the
MandNdimensions.For 1D results, add a
sum_then_bufferconfiguration which decides which kernel configuration to run.Sum_then_buffersums individual blocks of input and adds these sums into a buffer.Buffer_then_sumadds blocks of raw input into a buffer, then reduces the buffer.Reviewed By: davidberard98
Differential Revision: D58313958