Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FBGEMM submodule #2293

Closed
wants to merge 7 commits into from
Closed

Add FBGEMM submodule #2293

wants to merge 7 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Jun 11, 2024

This PR does the following:

  • Upgrade the default CUDA version to 12.4.
  • Pre-install fbgemm_gpu genai kernels to the nightly docker.

Test plan:

Build base image: https://github.com/pytorch/benchmark/actions/runs/9476276319
Build nightly docker: https://github.com/pytorch/benchmark/actions/runs/9486161032

cmd = ["pip", "install", "-r", "requirements.txt"]
subprocess.check_call(cmd, cwd=str(FBGEMM_PATH.resolve()))
# Build target A100(8.0) or H100(9.0)
cmd = [sys.executable, "setup.py", "bdist_wheel", "--package_variant=genai", "-DTORCH_CUDA_ARCH_LIST=8.0;9.0"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jianyuh Is this the right way to build FBGEMM GenAI OSS on A100/H100?

@xuzhao9 xuzhao9 requested a review from jianyuh June 12, 2024 16:28
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in abb45ae.

@xuzhao9 xuzhao9 deleted the xz9/add-fbgemm branch June 12, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants