Add command line argument parsing for reduction dimensions in Triton sum kernel #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sum kernel Summary: Add argument parsing for the command line in order to pass in dimension(s) across which the kernel reduces and enable more rigorous testing of different versions of the sum kernel, referencing [torchbenchmark/operators/fb/flash_attention/operator.py](https://www.internalfb.com/code/fbsource/[864a578ce44afdba619d50a352c8ca3b783e05ef]/fbcode/pytorch/benchmark/torchbenchmark/operators/fb/flash_attention/operator.py?lines=84). Inherit the `__init__` function from the parent class `BenchmarkOperator` in order to facilitate command line argument parsing. Change `dim` type to `list` to avoid type issues resulting from `tl.constexpr`. Modify equality checks in kernel and operator to satisfy type requirements for `dim`. Reviewed By: xuzhao9 Differential Revision: D58212366
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
This pull request was exported from Phabricator. Differential Revision: D58212366 |
|
This pull request has been merged in 9f2ab74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add argument parsing for the command line in order to pass in dimension(s) across which the kernel reduces and enable more rigorous testing of different versions of the sum kernel, referencing torchbenchmark/operators/fb/flash_attention/operator.py.
Inherit the
__init__function from the parent classBenchmarkOperatorin order to facilitate command line argument parsing.Change
dimtype tolistto avoid type issues resulting fromtl.constexpr.Modify equality checks in kernel and operator to satisfy type requirements for
dim.Reviewed By: xuzhao9
Differential Revision: D58212366