Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up UI for pytest machine config #204

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

wconstab
Copy link
Contributor

  • when exiting due to assertion, make the message more focused by
    avoiding pytests INTERNALERROR wrapper and whole stacktrace
  • also add suggestion of available --ignore_machine_config override

- when exiting due to assertion, make the message more focused by
  avoiding pytests INTERNALERROR wrapper and whole stacktrace
- also add suggestion of available --ignore_machine_config override
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wconstab wconstab merged commit ccea180 into master Jan 27, 2021
@wconstab wconstab deleted the wconstab/cleanup_machineconfig branch January 27, 2021 22:56
wconstab added a commit that referenced this pull request Feb 3, 2021
- when exiting due to assertion, make the message more focused by
  avoiding pytests INTERNALERROR wrapper and whole stacktrace
- also add suggestion of available --ignore_machine_config override
wconstab added a commit that referenced this pull request Feb 4, 2021
- when exiting due to assertion, make the message more focused by
  avoiding pytests INTERNALERROR wrapper and whole stacktrace
- also add suggestion of available --ignore_machine_config override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants