Deprecate torchtext dependent models and related code. #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Summary: This is a follow-up of #1831. Clip depends on torchmultimodal, which further depends on torchtext: https://github.com/pytorch/benchmark/actions/runs/5895605535/job/15991723413 Move the clip model to canary_models. Pull Request resolved: #1837 Reviewed By: msaroufim Differential Revision: D48480662 Pulled By: xuzhao9 fbshipit-source-id: da57c8aa3df4c520c6afae4342d365b166c8b2dd
xuzhao9
added a commit
that referenced
this pull request
Aug 22, 2023
xuzhao9
added a commit
that referenced
this pull request
Aug 22, 2023
Summary: torchtext is on a much lessen supported model, so we are deprecating the workload and make torchbench not depend on torchtext. Fixes #1830 Pull Request resolved: #1831 Reviewed By: abhinavarora Differential Revision: D48415274 Pulled By: xuzhao9 fbshipit-source-id: 9bb90ec3d84d2260b20cab1051d14c3d0a3129a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchtext is on a much lessen supported model, so we are deprecating the workload and make torchbench not depend on torchtext.
Fixes #1830