Remove jit from the framework code #1787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
H-Huang
added a commit
to pytorch/pytorch
that referenced
this pull request
Jul 27, 2023
Need to remove jit arguments after changes in pytorch/benchmark#1787 Also curious, is there is a procedure for updating torchbench version in Pytorch CI? cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
H-Huang
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 3, 2023
Need to remove jit arguments after changes in pytorch/benchmark#1787 Also curious, is there is a procedure for updating torchbench version in Pytorch CI? cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
H-Huang
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 3, 2023
Need to remove jit arguments after changes in pytorch/benchmark#1787 Also curious, is there is a procedure for updating torchbench version in Pytorch CI? cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
H-Huang
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 3, 2023
Need to remove jit arguments after changes in pytorch/benchmark#1787 Also curious, is there is a procedure for updating torchbench version in Pytorch CI? cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
H-Huang
added a commit
to pytorch/pytorch
that referenced
this pull request
Aug 3, 2023
Need to remove jit arguments after changes in pytorch/benchmark#1787 Also curious, is there is a procedure for updating torchbench version in Pytorch CI? cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 3, 2023
Need to remove jit arguments after changes in pytorch/benchmark#1787 Also curious, is there is a procedure for updating torchbench version in Pytorch CI? Pull Request resolved: #106071 Approved by: https://github.com/xuzhao9, https://github.com/msaroufim, https://github.com/malfet, https://github.com/lezcano
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 10, 2023
Continuous of #106071, without this dynamo dist cannot run at the moment. Related to pytorch/benchmark#1787 Pull Request resolved: #113338 Approved by: https://github.com/ezyang
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Continuous of pytorch#106071, without this dynamo dist cannot run at the moment. Related to pytorch/benchmark#1787 Pull Request resolved: pytorch#113338 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jit(torchscript) is now in archive mode and there is no need that we add it to the explicit options.
Jit(torchscript) is still supported with the extra args option
--backend torchsript.Fixes #1777