Adding missing self.loader #1148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
malfet
approved these changes
Sep 1, 2022
xuzhao9
pushed a commit
that referenced
this pull request
Sep 6, 2022
Summary: `get_module` later reads `self.loader` Pull Request resolved: #1148 Reviewed By: malfet Differential Revision: D39212518 Pulled By: xuzhao9 fbshipit-source-id: d389354db3f7eab5a18e3a529a704dc72f7a8f58
gairgeio
added a commit
to gairgeio/benchmark
that referenced
this pull request
Aug 2, 2024
Summary: `get_module` later reads `self.loader` Pull Request resolved: pytorch/benchmark#1148 Reviewed By: malfet Differential Revision: D39212518 Pulled By: xuzhao9 fbshipit-source-id: d389354db3f7eab5a18e3a529a704dc72f7a8f58
bestappsandcodereviews7
added a commit
to bestappsandcodereviews7/benchmark
that referenced
this pull request
Aug 16, 2024
Summary: `get_module` later reads `self.loader` Pull Request resolved: pytorch/benchmark#1148 Reviewed By: malfet Differential Revision: D39212518 Pulled By: xuzhao9 fbshipit-source-id: d389354db3f7eab5a18e3a529a704dc72f7a8f58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_modulelater readsself.loader