PEP 735: allow core metadata to include groups #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabc718
to
684221d
Compare
PEP 735 is expanded here to allow `project.dependencies` and `project.optional-dependencies` to use Dependency Group Includes. This allows for includes which help satisfy the use-cases described by the `--only-deps` pip use-cases. The changes for this are various: - support for these includes is added to the rationale section - a new use case is added, aligned with the `--only-deps` use case - the spec section is updated to list changes to the `project` table - backwards compatibility is extended significantly to address repackaging concerns as well as dependency analyzers[^1] - "how to teach this" is also extended to note compatibility and repackaging issues - rejected ideas has added an item on `[build-system.requires]` [^1]: It may be overstatement to say these concerns are addressed. They are considered and not dismissed, but it is not clear that any choices can be made in the spec to address these issues other than to inform users. Additionally, one unrelated change is included: the spec now notes explicitly that extra names and dependency group names can overlap (this was already possible, implicitly) and instructs tools to decide on their own how to handle that if they present dependency groups and extras via a uniform interface.
684221d
to
0fe570d
Compare
brettcannon
approved these changes
Sep 4, 2024
Co-authored-by: Brett Cannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 735 is expanded here to allow
project.dependenciesandproject.optional-dependenciesto use Dependency Group Includes. Thisallows for includes which help satisfy the use-cases described by the
--only-depspip use-cases.The changes are various:
--only-depsuse caseprojecttablerepackaging concerns as well as dependency analyzers1
repackaging issues
[build-system.requires]PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--3943.org.readthedocs.build/
Footnotes
It may be overstatement to say these concerns are addressed.
They are considered and not dismissed, but it is not clear that any
choices can be made in the spec to address these issues other than to
inform users. ↩