Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34736: improve error message for invalid length b64decode inputs #9563

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Sep 25, 2018

Improvements:

  1. Include the number of valid data characters in the error message.
  2. Mention "number of data characters" rather than "length".

https://bugs.python.org/issue34736

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 28, 2018
…ythonGH-9563)

Improvements:
1. Include the number of valid data characters in the error message.
2. Mention "number of data characters" rather than "length".

https://bugs.python.org/issue34736
(cherry picked from commit 1fba2ff)

Co-authored-by: Tal Einat <[email protected]>
@bedevere-bot
Copy link

GH-9614 is a backport of this pull request to the 3.7 branch.

@taleinat taleinat deleted the bpo-34736 branch September 28, 2018 06:01
miss-islington added a commit that referenced this pull request Sep 28, 2018
…H-9563)

Improvements:
1. Include the number of valid data characters in the error message.
2. Mention "number of data characters" rather than "length".

https://bugs.python.org/issue34736
(cherry picked from commit 1fba2ff)

Co-authored-by: Tal Einat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants