bpo-33151: Handle submodule resources #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Mar 27, 2018
| try: | ||
| return BytesIO(self.zipimporter.get_data(path)) | ||
| except OSError: | ||
| raise FileNotFoundError | ||
| raise FileNotFoundError(path) |
There was a problem hiding this comment.
Maybe use the repr() to help identify potentially odd things like whitespace issues?
There was a problem hiding this comment.
I thought about that, but I wanted the actual path string as the argument to the exception. I guess it's not that big a deal either way.
|
Thanks @warsaw for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6270 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 27, 2018
(cherry picked from commit 30e507d) Co-authored-by: Barry Warsaw <[email protected]>
warsaw
added a commit
that referenced
this pull request
Mar 27, 2018
(cherry picked from commit 30e507d) Co-authored-by: Barry Warsaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodule resources in zip files was semi-broken. This adds tests and should fix the problem.