bpo-36127: Fix compiler warning in _PyArg_UnpackKeywords(). #12353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Mar 18, 2019
| @@ -2422,7 +2422,7 @@ _PyArg_UnpackKeywords(PyObject *const *args, Py_ssize_t nargs, | |||
| } | |||
|
|
|||
| /* copy keyword args using kwtuple to drive process */ | |||
| for (i = Py_MAX(nargs, posonly); i < maxargs; i++) { | |||
| for (i = Py_MAX((int)nargs, posonly); i < maxargs; i++) { | |||
There was a problem hiding this comment.
I'm not sure that this code is safe is nargs > INT_MAX. (int)(INT_MAX+1) gives 0, no?
Maybe write something like:
i = (nargs < INT_MAX) ? (int)nargs : INT_MAX;
i = Py_MAX(i, posonly);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
nargs <= maxpos,nargscan be casted tointwithout lost.https://bugs.python.org/issue36127