gh-122334: Fix crash when importing ssl after re-initialization #122481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current METH_FASTCALL|METH_KEYWORDS functions in a non-builtin module can cause segfaults after restarting the main interpreter, invoking _PyArg_UnpackKeywords() with an insufficiently cleared _PyArg_Parser struct. This patch fixes the invalidation of the static argument parsers.
|
GH-122495 is a backport of this pull request to the 3.12 branch. |
|
This can be backported to 3.13. #122495 is a manual backport to 3.12. |
kumaraditya303
approved these changes
Aug 2, 2024
|
Thanks @neonene for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 2, 2024
…pythonGH-122481) * Fix crash when importing ssl after re-initialization (cherry picked from commit 9fc1c99) Co-authored-by: neonene <[email protected]>
|
GH-122614 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Aug 2, 2024
GH-122481) (#122495) Fix crash when importing ssl after re-initialization The current METH_FASTCALL|METH_KEYWORDS functions in a non-builtin module can cause segfaults after restarting the main interpreter, invoking _PyArg_UnpackKeywords() with an insufficiently cleared _PyArg_Parser struct. This patch fixes the invalidation of the static argument parsers.
|
Thanks. |
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Aug 7, 2024
…python#122481) * Fix crash when importing ssl after re-initialization
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…python#122481) * Fix crash when importing ssl after re-initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
METH_FASTCALL|METH_KEYWORDSfunctions in a non-builtin module can cause segfaults after restarting the main interpreter, invoking_PyArg_UnpackKeywords()with an insufficiently cleared_PyArg_Parserstruct.This patch fixes the invalidation of the static argument parsers.