gh-121794: Don't set ob_tid
to zero in fast-path dealloc
#121799
Merged
+62
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should maintain the invariant that a zero
ob_tid
implies the refcount fields are merged._Py_MergeZeroLocalRefcount
to immediately before the refcount merge._PyTrash_thread_destroy_chain
to setob_ref_shared
to_Py_REF_MERGED
when settingob_tid
to zero.Also check this invariant with assertions in the GC in debug builds. That uncovered a bug when running out of memory during GC.
_Py_MergeZeroLocalRefcount
should not setob_tid
to zero in fast-path dealloc #121794