Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120831: Increase the default minimum supported iOS version to 13.0 #121250

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Jul 2, 2024

Bumps the default minimum iOS version from 12.0 to 13.0.

As discussed on #120831, the previous default value of 12.0 worked successfully at runtime, but raised a compilation warning about the usage of an SQLite API that wasn't added until iOS 13.0. Although protection exists in the code to prevent any runtime problem, avoiding the compilation warning was judged to be more important.

The usage of iOS 12 is estimated to be less that 0.5% of the total iOS install base, so the impact on the user base is minor. It's also only a default version; it's possible to manually configure any minimum version at compile time.

In addition to increasing the default minimum version, this PR modifies the logging generated by the configure script to be more explicit about the iOS deployment target (aka minimum version) that will be used. It also adds usage documentation about the default iOS supported version.

The buildbot will still generate the warning because it the iOS buildbot configuration currently hard-codes the 12.0 minimum supported version. I'll push an update for the buildbot configuration shortly.

Fixes #120831.


📚 Documentation preview 📚: https://cpython-previews--121250.org.readthedocs.build/

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 20209cd 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 20209cd 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

The new buildbot configuration has been deployed; this build shows an auto detected iOS 13 minimum, and no build warnings (compared to the previous PR build, which shows 2 warnings associated with the SQLite issue).

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a tiny nit.

Doc/using/ios.rst Outdated Show resolved Hide resolved
Co-authored-by: Erlend E. Aasland <[email protected]>
@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

1 similar comment
@zware
Copy link
Member

zware commented Jul 12, 2024

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit cbd760e 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@zware
Copy link
Member

zware commented Jul 12, 2024

Found how I broke it...

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @zware for commit cbd760e 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit cbd760e 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742 freakboy3742 merged commit 7e91e0d into python:main Jul 16, 2024
36 of 37 checks passed
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@freakboy3742 freakboy3742 deleted the ios-minversion branch July 16, 2024 04:23
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2024
…o 13.0 (pythonGH-121250)

Increases the default minimum iOS version to 13.0.

(cherry picked from commit 7e91e0d)

Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 16, 2024

GH-121833 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 16, 2024
@freakboy3742
Copy link
Contributor Author

For posterity - merged despite the CI failures. The CI failures are due to #121832; local testing and inspection of the CI logs demonstrates that the new minimum version is being applied.

freakboy3742 added a commit that referenced this pull request Jul 16, 2024
…to 13.0 (GH-121250) (#121833)

gh-120831: Increase the default minimum supported iOS version to 13.0 (GH-121250)

Increases the default minimum iOS version to 13.0.

(cherry picked from commit 7e91e0d)

Co-authored-by: Russell Keith-Magee <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…o 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Aug 5, 2024
…rsion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Aug 5, 2024
…rsion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Aug 5, 2024
…rsion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Aug 5, 2024
…sion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 6, 2024
…rsion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…rsion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…rsion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…rsion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Sep 9, 2024
…sion to 13.0 (python#121250)

Increases the default minimum iOS version to 13.0.

Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes OS-ios
Projects
None yet
5 participants