Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35225: Fix typos in test_faulthandler skipIfs for ubsan. #11386

Merged
merged 1 commit into from
Dec 31, 2018
Merged

bpo-35225: Fix typos in test_faulthandler skipIfs for ubsan. #11386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/test/test_faulthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
_cflags = sysconfig.get_config_var('CFLAGS') or ''
_config_args = sysconfig.get_config_var('CONFIG_ARGS') or ''
UB_SANITIZER = (
'-fsanitizer=undefined' in _cflags or
'-fsanitize=undefined' in _cflags or
'--with-undefined-behavior-sanitizer' in _config_args
)
MEMORY_SANITIZER = (
'-fsanitizer=memory' in _cflags or
'-fsanitize=memory' in _cflags or
'--with-memory-sanitizer' in _config_args
)

Expand Down Expand Up @@ -265,7 +265,7 @@ def test_gil_released(self):
'Segmentation fault')

@unittest.skipIf(UB_SANITIZER or MEMORY_SANITIZER,
"sanizer builds change crashing process output.")
"sanitizer builds change crashing process output.")
@skip_segfault_on_android
def test_enable_file(self):
with temporary_filename() as filename:
Expand All @@ -282,7 +282,7 @@ def test_enable_file(self):
@unittest.skipIf(sys.platform == "win32",
"subprocess doesn't support pass_fds on Windows")
@unittest.skipIf(UB_SANITIZER or MEMORY_SANITIZER,
"sanizer builds change crashing process output.")
"sanitizer builds change crashing process output.")
@skip_segfault_on_android
def test_enable_fd(self):
with tempfile.TemporaryFile('wb+') as fp:
Expand Down