bpo-35623: Fix integer overflow when sorting large lists #11380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a `Py_ssize_t i` defined at function scope that is used for similar loops. By removing the local `int i` declaration that `i` is used, which has the appropriate type.
Misc/NEWS.d/next/Core and Builtins/2018-12-31-02-37-20.bpo-35623.24AQhY.rst
Outdated
Show resolved
Hide resolved
Co-Authored-By: sth <[email protected]>
|
It's always nice when you can fix overflows by deleting a line. Thanks! |
|
Thanks @sth for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-11401 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 2, 2019
…onGH-11380) There is already a `Py_ssize_t i` defined at function scope that is used for similar loops. By removing the local `int i` declaration that `i` is used, which has the appropriate type. (cherry picked from commit f8b5344) Co-authored-by: sth <[email protected]>
|
Sorry, @sth and @benjaminp, I could not cleanly backport this to |
|
Sorry, @sth and @benjaminp, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Jan 2, 2019
…1380) There is already a `Py_ssize_t i` defined at function scope that is used for similar loops. By removing the local `int i` declaration that `i` is used, which has the appropriate type. (cherry picked from commit f8b5344) Co-authored-by: sth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
list_sort_impl()in one case anint iis used to track the number of elements while sorting. With a large list this can lead to an integer overflow. This happens when runningtest_bigmemwith enough memory.There is already a
Py_ssize_t idefined at function scope that is usedfor similar loops. By removing the local
int ideclaration thatifrom function scope isused, which has the appropriate type.
https://bugs.python.org/issue35623