Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "bpo-35603: Escape table header of make_table output that can cause potential XSS" #11356

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Revert "bpo-35603: Escape table header of make_table output that can cause potential XSS" #11356

merged 1 commit into from
Jan 2, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 29, 2018 •
edited by bedevere-bot

tirkarthi
tirkarthi approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be documented instead of changing the behaviora as noted in the issue. Sorry for the false positive.

@serhiy-storchaka serhiy-storchaka merged commit 830ddc7 into master Jan 2, 2019
@serhiy-storchaka serhiy-storchaka deleted the revert-11341-bpo35603 branch January 2, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@serhiy-storchaka @tirkarthi @the-knights-who-say-ni @bedevere-bot