Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-22831: Use "with" to avoid possible fd leaks in tools (part 1). #10926

Merged
merged 3 commits into from
Mar 30, 2019
Merged

bpo-22831: Use "with" to avoid possible fd leaks in tools (part 1). #10926

merged 3 commits into from
Mar 30, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 5, 2018 •
edited by bedevere-bot
Loading

matrixise
matrixise approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @serhiy-storchaka this PR seems to be ok, I am going to check the second part (https://github.com/python/cpython/pull/10927/files)

@serhiy-storchaka serhiy-storchaka merged commit afbb7a3 into python:master Mar 30, 2019
@serhiy-storchaka serhiy-storchaka deleted the fd-leaks-tools1 branch March 30, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmium vadmium vadmium left review comments

@matrixise matrixise matrixise approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @matrixise @vadmium @the-knights-who-say-ni @bedevere-bot