-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_Py_FinishPendingCalls() Doesn't Necessarily Run All Remaining Pending Calls #118297
Labels
3.12
bugs and security fixes
3.13
bugs and security fixes
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
type-bug
An unexpected behavior, bug, or error
Comments
ericsnowcurrently
added
type-bug
An unexpected behavior, bug, or error
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
3.12
bugs and security fixes
3.13
bugs and security fixes
labels
Apr 25, 2024
ericsnowcurrently
added a commit
that referenced
this issue
Jul 15, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 15, 2024
…Calls() (pythongh-118298) (cherry picked from commit 985dd8e) Co-authored-by: Eric Snow <[email protected]>
ericsnowcurrently
added a commit
that referenced
this issue
Jul 15, 2024
…gCalls() (gh-121806) (cherry picked from commit 985dd8e, AKA gh-118298) Co-authored-by: Eric Snow <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this issue
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.12
bugs and security fixes
3.13
bugs and security fixes
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
type-bug
An unexpected behavior, bug, or error
Bug report
Bug description:
In Python/ceval_gil.c,
_Py_FinishPendingCalls()
callsmake_pending_calls()
once.make_pending_calls()
will fail with the first pending call that fails (returns a non-zero value), leaving any remaining pending calls in the queue._Py_FinishPendingCalls()
basically throws away the error and walks away.Instead,
_Py_FinishPendingCalls()
should keep trying until there are no pending calls left in the queue.(I found this while working on gh-110693.)
CPython versions tested on:
3.13
Operating systems tested on:
No response
Linked PRs
The text was updated successfully, but these errors were encountered: