Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative build path issue #9433

Merged
merged 2 commits into from
May 28, 2024

Conversation

OhioDschungel6
Copy link
Contributor

@OhioDschungel6 OhioDschungel6 commented May 21, 2024

Pull Request Check List

Resolves: #9432

  • Added tests for changed code.
  • Updated documentation for changed code.

@OhioDschungel6
Copy link
Contributor Author

Hey, this is my first time contributing.
I have not changed the docs, because the fixed behavior is intended and was already documented.
I was not able to write a reproducing test in "test_build.py" as this seems to circumvent the "application.py" module.
Also a nested src folder is needed as shown in the issue.
The simplest way to reproduce the issue is to check out the poetry repo and try: "poetry build -C ."

@radoering
Copy link
Member

I added a test, which was a bit tricky for sure. You have to choose ApplicationTester instead of CommandTester (in comparison to the other tests in test_build.py) because the latter initializes Poetry before the directory is passed. But even when using the correct tester class, at first, I was not able to reproduce the issue because of #9444.

@OhioDschungel6
Copy link
Contributor Author

@radoering nice! thanks for the help

@radoering radoering merged commit 108d732 into python-poetry:main May 28, 2024
60 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry build -C ./relative/path doesnt work properly
2 participants