Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to native tags gathering #9304

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Apr 12, 2024

Pull Request Check List

Resolves: None

- [ ] Added tests for changed code. New code doesn't change the behavior
- [ ] Updated documentation for changed code. No user-facing changes

The scripts connected to envs bothered me for quite a while. I have found a way to remove GET_SYS_TAGS script, by replacing it with a native implementation. I have also included a few small improvements.

@Secrus Secrus requested a review from a team April 14, 2024 13:09
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just two questions.

pyproject.toml Show resolved Hide resolved
src/poetry/utils/env/script_strings.py Show resolved Hide resolved
@Secrus Secrus merged commit 93ef49f into python-poetry:main Apr 17, 2024
60 checks passed
@Secrus Secrus deleted the packaging-script branch April 17, 2024 23:10
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants