Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #9283

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Misc fixes #9283

merged 5 commits into from
Apr 8, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Apr 7, 2024

another small collection of small fixes

  • simplify and correct handling of metadata fixtures in tests: metadata should be read as bytes, not text, and then the code is common
  • some highly pedantic typechecking fixes after I accidentally ran pyright over the codebase. (pyright gives plenty of other warnings, mostly complaining about tomlkit, the things changed here are the ones that looked halfway interesting)
  • update build. See build: add editable to dist type pypa/build#764 re the typing, their next release will once again consider "editable" to be ok
  • transitive dependencies are "transitive" not "transient"
  • remove some python 3.7 typechecking trickery that is no longer necessary

@Secrus Secrus merged commit 29d3c5f into python-poetry:main Apr 8, 2024
60 checks passed
@dimbleby dimbleby deleted the misc-fixes branch April 8, 2024 11:48
Copy link

github-actions bot commented May 9, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants