Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerate funky group names at 'poetry add' #9277

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Apr 5, 2024

when adding a dependency to a new group, build up the toml data structure directly - rather than by string parsing (and forgetting to do enough escaping)

fixes #8980

@radoering radoering merged commit 9d9bcf1 into python-poetry:main Apr 7, 2024
60 checks passed
@dimbleby dimbleby deleted the add-unusual-group-names branch April 7, 2024 11:47
Copy link

github-actions bot commented May 8, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message to EmptyTableNameError
2 participants