Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy-wheel: handle internal server error and others #9030

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

radoering
Copy link
Member

@radoering radoering commented Feb 26, 2024

if the server returns an internal server error (500), it probably does not support negative offsets

Pull Request Check List

Resolves: #9026 #9033

  • Added tests for changed code.
  • Updated documentation for changed code.

Secrus
Secrus previously approved these changes Feb 26, 2024
@Secrus
Copy link
Member

Secrus commented Feb 26, 2024

Take a look at #9033, maybe we can fix that as well?

@radoering radoering changed the title lazy-wheel: handle internal server error lazy-wheel: handle internal server error and others Feb 26, 2024
…upported"

not all servers return "method not allowed" or "not implemented", but for example also "internal server error" or "not found"
@abn abn merged commit 8c9a80e into python-poetry:main Feb 26, 2024
20 checks passed
@david-nano
Copy link

david-nano commented Feb 26, 2024

@abn which version will include this fix?

@abn
Copy link
Member

abn commented Feb 26, 2024

@david-nano we are hoping we can get a 1.8.1 release out sooner rather than later. Depends on how much time we are able to find.

@Symbianx
Copy link

We also just found this problem and it's breaking all service builds. Is there any chance we can get a patch released soon?

@radoering
Copy link
Member Author

#9036

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8 Backport a PR to 1.8 through an automated PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing private packages from GAR in Docker build fails with 500 Internal Server Error on Poetry 1.8.0
5 participants