Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to old scripts extras feature #8903

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Jan 24, 2024

Resolves: #8902

@Secrus Secrus added the impact/docs Contains or requires documentation changes label Jan 24, 2024
Copy link

github-actions bot commented Jan 24, 2024

Deploy preview for website ready!

✅ Preview
https://website-bq7pvmj9e-python-poetry.vercel.app

Built with commit 58cd7a0.
This pull request is being automatically deployed with vercel-action

@radoering
Copy link
Member

We probably should print a deprecation warning somewhere as proposed in the issue.

@Secrus
Copy link
Member Author

Secrus commented Jan 24, 2024

We probably should print a deprecation warning somewhere as proposed in the issue.

Yeah, that would be a separate PR in core, as that's where the code is.

@radoering
Copy link
Member

Do you want to create that PR? I feel like we should undocument and deprecate it at the same time. It don't like the idea to make this an undocumented but not yet deprecated feature.

@radoering
Copy link
Member

I just created python-poetry/poetry-core#690 so we might include it in the next release.

@Secrus Secrus requested a review from a team January 27, 2024 21:51
@radoering radoering merged commit ed1dcdd into python-poetry:master Jan 28, 2024
18 checks passed
@Secrus Secrus deleted the extras-docs branch March 2, 2024 19:34
Copy link

github-actions bot commented Apr 2, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console scripts dependant on extras is officially discouraged
2 participants