Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install console script with extras #8900

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Conversation

couling
Copy link
Contributor

@couling couling commented Jan 23, 2024

Pull Request Check List

Resolves: #8899

  • Added tests for changed code.
  • Updated documentation for changed code.

Credit to @snorfalorpagus for finding the fix

In the documented example, poetry install should generate a python file named devtest to run test.run_tests() NOT `test.run_teststest

@couling
Copy link
Contributor Author

couling commented Jan 23, 2024

I've not had chance to figure out how to unit test this yet, but wanted to make the fix available.

@couling
Copy link
Contributor Author

couling commented Jan 24, 2024

The BSD tests seem to have had a problem in CI pipeline unrelated to the code change. Perhaps someone could re-run them to confirm.

@Secrus Secrus merged commit 312bb7a into python-poetry:master Jan 27, 2024
20 checks passed
@couling couling deleted the patch-1 branch January 27, 2024 23:31
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry install generates invalid python code for console scrips dependent on extras
2 participants