Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env: delete entry in envs.toml when running poetry env remove --all #8831

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

radoering
Copy link
Member

Pull Request Check List

Resolves: #8631
Closes: #8665

  • Added tests for changed code.
  • Updated documentation for changed code.

Alternative approach to #8665. Just remove the entry in envs.toml when running poetry env remove --all. This even covers the case that the entry refers to a virtualenv that had been removed manually before.

The actual change is in remove.py. Changes in env_manager.py are just refactorings to avoid code duplication and document the envs.toml file a little bit better.

@Secrus Secrus merged commit 022308e into python-poetry:master Jan 4, 2024
20 checks passed
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry fails to use the currently activated environnement
2 participants