run python scripts as "python -c text" #8565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and not as "python -", and then passing the script as input
this sidesteps encoding issues, fixes #8550
comments:
subprocess.run()
are now executed viasubprocess.check_output()
run_python_script
was the only caller making use ofinput_
in this code, I've removed thesubprocess.run()
branch altogetherlen(GET_ENVIRONMENT_INFO)
is 1717, the Windows limit should be 8191, it's much larger elsewhereenv_manager.py