fix: error when lockfile without metadata entry is encountered #8523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this, you'll get a cryptic 'metadata' in red when running `poetry install` this can occur if a poetry.lock file is empty
|
This test should be quite similar. Please also pay attention to the failing pre-commit pipeline. cf https://python-poetry.org/docs/contributing#local-development |
|
added test + fixed linting |
eamanu
approved these changes
Oct 12, 2023
radoering
approved these changes
Oct 14, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, you'll get a cryptic 'metadata' in red when running
poetry install. This can occur if a poetry.lock file is emptyNot sure of the best way to write a test for this, point me in the right direction and I'll write a test.
Pull Request Check List