Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-cache-dir to user-facing error message about PEP-517 support. #8463

Merged
merged 5 commits into from
Sep 23, 2023

Conversation

itsjamie
Copy link
Contributor

@itsjamie itsjamie commented Sep 22, 2023

Pull Request Check List

Resolves: #8462

  • Added tests for changed code.
  • Updated documentation for changed code.

As mentioned in the issue, this would have saved me some time and the contributors.

When trying to determine if the issue was because of Poetry or the package not supporting PEP-517 mode, it is possible that the pip cache can result in false positives of packages that support PEP-517. An example of this is the issue python-poetry#8462. 

This PR adds to the error output and recommended command to prevent this from happening in the future.

As a new user to Python, it wasn't immediately obvious to me when running on the command line why it succeeded, and simply took that it did as enough confirmation that opening an issue was valid.
@itsjamie itsjamie changed the title Patch 1 Add --no-cache-dir to user-facing error message about PEP-517 support. Sep 22, 2023
@radoering radoering merged commit c9fbd5a into python-poetry:master Sep 23, 2023
20 checks passed
@itsjamie itsjamie deleted the patch-1 branch September 24, 2023 01:15
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aeneas build fails in Poetry, succeeds with pip wheel --use-pep517
2 participants