-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix urljoin for arbitrary URL protocols #8020
Conversation
I can't tell what this fixes, a test case showing the point would be helpful |
This works around an issue with urllib.parse.urljoin where it only handles relative URLs for protocols contained in urllib.parse.uses_relative. As it happens common protocols used with git, like ssh or git+ssh are not in that list.
@dimbleby, I've added tests. Doing so required a bit of refactoring to make testing easier since actually cloning the test repo via SSH would require significant effort without a correspondingly large benefit. The core the of the change, as before, is |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This works around an issue with urllib.parse.urljoin where it only handles relative URLs for protocols contained in urllib.parse.uses_relative. As it happens common protocols used with git, like ssh or git+ssh are not in that list.
For more info: #6499 (comment)
Pull Request Check List
Resolves: #6499