Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve relative-path at poetry run #7963

Merged
merged 1 commit into from
May 21, 2023

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented May 19, 2023

fixes #7959

a regression introduced in the effort to use Path for paths. Turns out that Env._bin() isn't really returning a path at all, it's returning a thing that you pass to subprocess.Popen()

In particular, Path("./foo.py") is the same as Path("foo.py")

@radoering radoering added impact/backport Requires backport to stable branch backport/1.5 labels May 21, 2023
@radoering radoering merged commit ebadf8a into python-poetry:master May 21, 2023
16 checks passed
poetry-bot bot pushed a commit that referenced this pull request May 21, 2023
radoering pushed a commit that referenced this pull request May 21, 2023
@dimbleby dimbleby deleted the fix-poetry-run branch May 21, 2023 15:51
@djch
Copy link

djch commented May 22, 2023

Nice to see this was addressed already 🙂

I'm hoping this one can go out in a bug fix release ASAP. I've got a lot of scripts in a lot of Django projects which call ./manage.py.

In the mean time, can I run poetry self update *something* to install poetry from master and get this fix?

@radoering
Copy link
Member

In the mean time, can I run poetry self update *something* to install poetry from master and get this fix?

Not sure about poetry self but if you use pipx, you can install the 1.5 branch (from which 1.5.1 will be built) via

pipx install git+https://github.com/python-poetry/[email protected]

Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry run no longer executes local bash scripts
3 participants