Error when invalid groups are referenced #7529

samypr100 · 2023-02-17T15:26:42Z

Pull Request Check List

Resolves: #7303

Edit (Apr 3rd 2023): Changed implementation from warning to an error.

Added tests for changed code.
Updated documentation for changed code.

This PR raises a new GroupNotFound error when groups that do not exist in pyproject.toml are used with --with, --without, and --only flags as indicated in #7303 to help the user encounter mistakes related to this early on (instead of silently proceeding as it does now).

Edit (Apr 4th 2023): Latest Output Below

johnthagen · 2023-02-20T13:34:48Z

My personal preference would be for an error here as it seems like an error would only catch legitimate typos (in CI configurations, etc), but happy to hear what the Poetry devs think. I think an error would help projects keep typos out of their project CI if typos trigger failures in their CI.

adriangb · 2023-02-26T17:14:52Z

I would also vote for an error.

johnthagen · 2023-03-22T12:15:24Z

@radoering Would you or someone on the Poetry team be able to review this PR? We'd really appreciate having Poetry catch more typos in CI configurations and end user machines. Thanks.

radoering

Although I'd also prefer an error, it's true that it can be considered a breaking change. So maybe we leave it a warning for now and add to it something like "This may lead to an error in an upcoming minor release."?

src/poetry/console/commands/group_command.py

radoering · 2023-03-24T04:58:26Z

@johnthagen You have convinced me. Any change (or even bugfix) is a breaking change for someone out there. I can't imagine non-existent groups being intentionally used in a meaningful way by someone. So let's consider it a bug that invalid groups are accepted and make it an error.

samypr100 · 2023-04-03T20:35:05Z

@radoering I've updated the implementation in 489c466 to raise an error, thanks!

docs/managing-dependencies.md

src/poetry/console/commands/group_command.py

src/poetry/exceptions.py

samypr100 · 2023-04-04T16:49:28Z

@radoering Should be ready

src/poetry/console/commands/group_command.py

Co-authored-by: Randy Döring <[email protected]>

Removing extraneous docs Collapsing error output into single Exception Migrating GroupNotFound to console.exceptions

Co-authored-by: Randy Döring <[email protected]>

samypr100 · 2023-04-05T13:39:02Z

@radoering Applied suggestions and rebased

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [poetry](https://python-poetry.org/) ([source](https://github.com/python-poetry/poetry), [changelog](https://python-poetry.org/history/)) | minor | `1.4.2` -> `1.5.0` | --- ### Release Notes <details> <summary>python-poetry/poetry</summary> ### [`v1.5.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#150---2023-05-19) [Compare Source](python-poetry/poetry@1.4.2...1.5.0) ##### Added - **Introduce the new source priorities `explicit` and `supplemental`** ([#7658](python-poetry/poetry#7658), [#6879](python-poetry/poetry#6879)). - **Introduce the option to configure the priority of the implicit PyPI source** ([#7801](python-poetry/poetry#7801)). - Add handling for corrupt cache files ([#7453](python-poetry/poetry#7453)). - Improve caching of URL and git dependencies ([#7693](python-poetry/poetry#7693), [#7473](python-poetry/poetry#7473)). - Add option to skip installing directory dependencies ([#6845](python-poetry/poetry#6845), [#7923](python-poetry/poetry#7923)). - Add `--executable` option to `poetry env info` ([#7547](python-poetry/poetry#7547)). - Add `--top-level` option to `poetry show` ([#7415](python-poetry/poetry#7415)). - Add `--lock` option to `poetry remove` ([#7917](python-poetry/poetry#7917)). - Add experimental `POETRY_REQUESTS_TIMEOUT` option ([#7081](python-poetry/poetry#7081)). - Improve performance of wheel inspection by avoiding unnecessary file copy operations ([#7916](python-poetry/poetry#7916)). ##### Changed - **Remove the old deprecated installer and the corresponding setting `experimental.new-installer`** ([#7356](python-poetry/poetry#7356)). - **Introduce `priority` key for sources and deprecate flags `default` and `secondary`** ([#7658](python-poetry/poetry#7658)). - Deprecate `poetry run <entry point>` if the entry point was not previously installed via `poetry install` ([#7606](python-poetry/poetry#7606)). - Only write the lock file if the installation succeeds ([#7498](python-poetry/poetry#7498)). - Do not write the unused package category into the lock file ([#7637](python-poetry/poetry#7637)). ##### Fixed - Fix an issue where Poetry's internal pyproject.toml continually grows larger with empty lines ([#7705](python-poetry/poetry#7705)). - Fix an issue where Poetry crashes due to corrupt cache files ([#7453](python-poetry/poetry#7453)). - Fix an issue where the `Retry-After` in HTTP responses was not respected and retries were handled inconsistently ([#7072](python-poetry/poetry#7072)). - Fix an issue where Poetry silently ignored invalid groups ([#7529](python-poetry/poetry#7529)). - Fix an issue where Poetry does not find a compatible Python version if not given explicitly ([#7771](python-poetry/poetry#7771)). - Fix an issue where the `direct_url.json` of an editable install from a git dependency was invalid ([#7473](python-poetry/poetry#7473)). - Fix an issue where error messages from build backends were not decoded correctly ([#7781](python-poetry/poetry#7781)). - Fix an infinite loop when adding certain dependencies ([#7405](python-poetry/poetry#7405)). - Fix an issue where pre-commit hooks skip pyproject.toml files in subdirectories ([#7239](python-poetry/poetry#7239)). - Fix an issue where pre-commit hooks do not use the expected Python version ([#6989](python-poetry/poetry#6989)). - Fix an issue where an unclear error message is printed if the project name is the same as one of its dependencies ([#7757](python-poetry/poetry#7757)). - Fix an issue where `poetry install` returns a zero exit status even though the build script failed ([#7812](python-poetry/poetry#7812)). - Fix an issue where an existing `.venv` was not used if `in-project` was not set ([#7792](python-poetry/poetry#7792)). - Fix an issue where multiple extras passed to `poetry add` were not parsed correctly ([#7836](python-poetry/poetry#7836)). - Fix an issue where `poetry shell` did not send a newline to `fish` ([#7884](python-poetry/poetry#7884)). - Fix an issue where `poetry update --lock` printed operations that were not executed ([#7915](python-poetry/poetry#7915)). - Fix an issue where `poetry add --lock` did perform a full update of all dependencies ([#7920](python-poetry/poetry#7920)). - Fix an issue where `poetry shell` did not work with `nushell` ([#7919](python-poetry/poetry#7919)). - Fix an issue where subprocess calls failed on Python 3.7 ([#7932](python-poetry/poetry#7932)). - Fix an issue where keyring was called even though the password was stored in an environment variable ([#7928](python-poetry/poetry#7928)). ##### Docs - Add information about what to use instead of `--dev` ([#7647](python-poetry/poetry#7647)). - Promote semantic versioning less aggressively ([#7517](python-poetry/poetry#7517)). - Explain Poetry's own versioning scheme in the FAQ ([#7517](python-poetry/poetry#7517)). - Update documentation for configuration with environment variables ([#6711](python-poetry/poetry#6711)). - Add details how to disable the virtualenv prompt ([#7874](python-poetry/poetry#7874)). - Improve documentation on whether to commit `poetry.lock` ([#7506](python-poetry/poetry#7506)). - Improve documentation of `virtualenv.create` ([#7608](python-poetry/poetry#7608)). ##### poetry-core ([`1.6.0`](https://github.com/python-poetry/poetry-core/releases/tag/1.6.0)) - Improve error message for invalid markers ([#569](python-poetry/poetry-core#569)). - Increase robustness when deleting temporary directories on Windows ([#460](python-poetry/poetry-core#460)). - Replace `tomlkit` with `tomli`, which changes the interface of some *internal* classes ([#483](python-poetry/poetry-core#483)). - Deprecate `Package.category` ([#561](python-poetry/poetry-core#561)). - Fix a performance regression in marker handling ([#568](python-poetry/poetry-core#568)). - Fix an issue where wildcard version constraints were not handled correctly ([#402](python-poetry/poetry-core#402)). - Fix an issue where `poetry build` created duplicate Python classifiers if they were specified manually ([#578](python-poetry/poetry-core#578)). - Fix an issue where local versions where not handled correctly ([#579](python-poetry/poetry-core#579)). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.walbeck.it/walbeck-it/docker-python-poetry/pulls/717 Co-authored-by: renovate-bot <[email protected]> Co-committed-by: renovate-bot <[email protected]>

python-poetry/poetry#7529 Signed-off-by: Andrews Arokiam <[email protected]>

* Upgraded poetry version to 1.7.1 Signed-off-by: Andrews Arokiam <[email protected]> * fixed poetry install with invalid group. python-poetry/poetry#7529 Signed-off-by: Andrews Arokiam <[email protected]> --------- Signed-off-by: Andrews Arokiam <[email protected]>

github-actions · 2024-03-03T21:04:05Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

samypr100 force-pushed the invalid-group-names-warning branch from 2e14d41 to ed4c0ba Compare February 17, 2023 20:45

johnthagen mentioned this pull request Feb 25, 2023

Support installing Poetry dependency groups cjolowicz/nox-poetry#1080

Open

radoering reviewed Mar 22, 2023

View reviewed changes

src/poetry/console/commands/group_command.py Outdated Show resolved Hide resolved

samypr100 force-pushed the invalid-group-names-warning branch from e5e811b to f80e97a Compare April 3, 2023 14:06

samypr100 changed the title ~~Warning when invalid groups are referenced~~ Error when invalid groups are referenced Apr 3, 2023

radoering requested changes Apr 4, 2023

View reviewed changes

samypr100 requested a review from radoering April 4, 2023 13:59

radoering requested changes Apr 5, 2023

View reviewed changes

src/poetry/console/commands/group_command.py Outdated Show resolved Hide resolved

src/poetry/console/commands/group_command.py Outdated Show resolved Hide resolved

samypr100 and others added 7 commits April 5, 2023 09:36

Warning when invalid groups are referenced

141f4fb

Update src/poetry/console/commands/group_command.py

70207f9

Co-authored-by: Randy Döring <[email protected]>

Raise error when encountering invalid groups

90c5489

Addressing PR feedback

bcd5401

Removing extraneous docs Collapsing error output into single Exception Migrating GroupNotFound to console.exceptions

Simplifying Exception Message

08ab3ea

Apply suggestions from code review

fe83b63

Co-authored-by: Randy Döring <[email protected]>

Post feedback cleanup

25ae7c7

samypr100 force-pushed the invalid-group-names-warning branch from 6201edb to 25ae7c7 Compare April 5, 2023 13:37

radoering approved these changes Apr 5, 2023

View reviewed changes

radoering enabled auto-merge (squash) April 5, 2023 13:47

radoering merged commit 7585c37 into python-poetry:master Apr 5, 2023

radoering mentioned this pull request May 18, 2023

release: bump version to 1.5.0 #7947

Merged

nils-van-zuijlen mentioned this pull request May 22, 2023

Hook fails because there are no dev dependency group in our poetry config Lucas-C/pre-commit-hooks-safety#44

Closed

dimbleby mentioned this pull request May 23, 2023

Issue with --without flag #7991

Closed

samypr100 deleted the invalid-group-names-warning branch June 2, 2023 16:50

andyi2it added a commit to andyi2it/kserve that referenced this pull request Dec 7, 2023

fixed poetry install with invalid group.

5fa2f37

python-poetry/poetry#7529 Signed-off-by: Andrews Arokiam <[email protected]>

radoering mentioned this pull request Feb 4, 2024

Ignore dependency groups that do not exist on --with and --without. #8906

Closed

2 tasks

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error when invalid groups are referenced #7529

Error when invalid groups are referenced #7529

samypr100 commented Feb 17, 2023 •

edited

Loading

johnthagen commented Feb 20, 2023 •

edited

Loading

adriangb commented Feb 26, 2023

johnthagen commented Mar 22, 2023

radoering left a comment

radoering commented Mar 24, 2023

samypr100 commented Apr 3, 2023 •

edited

Loading

samypr100 commented Apr 4, 2023

samypr100 commented Apr 5, 2023

github-actions bot commented Mar 3, 2024

Error when invalid groups are referenced #7529

Error when invalid groups are referenced #7529

Conversation

samypr100 commented Feb 17, 2023 • edited Loading

Pull Request Check List

johnthagen commented Feb 20, 2023 • edited Loading

adriangb commented Feb 26, 2023

johnthagen commented Mar 22, 2023

radoering left a comment

Choose a reason for hiding this comment

radoering commented Mar 24, 2023

samypr100 commented Apr 3, 2023 • edited Loading

samypr100 commented Apr 4, 2023

samypr100 commented Apr 5, 2023

github-actions bot commented Mar 3, 2024

samypr100 commented Feb 17, 2023 •

edited

Loading

johnthagen commented Feb 20, 2023 •

edited

Loading

samypr100 commented Apr 3, 2023 •

edited

Loading