markers: add special handling for extra
#636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
force-pushed
the
extra-marker
branch
from
9563c02
to
973f2b7
Compare
dimbleby
reviewed
Sep 9, 2023
radoering
force-pushed
the
extra-marker
branch
2 times, most recently
from
e1d4136
to
532cec2
Compare
Secrus
approved these changes
Sep 11, 2023
radoering
force-pushed
the
extra-marker
branch
from
532cec2
to
b91e1df
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Oct 30, 2023
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extrais not like any other marker, it is, well, "extra". Whereas normal markers can only have one value at a time,extracan have multiple values at the same time.For example, a marker like
sys_platform == "win32" and sys_platform == "linux"can never be fulfilled becausesys_platformcan only be either"win32"or"linux"(not both). By contrast, a marker likeextra == "a" and extra == "b"can be fulfilled if both extras are requested.Therefore, this PR disables some simplifications for
extramarkers. Further, it adds the option to validate environments with multiple extras and makes the validation robust against unnormalized names.