Explicitly define the build/lib* paths #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbotorigami
changed the title
robbotorigami
force-pushed
the
fix_build_directories
branch
from
adc4aed
to
3155ce5
Compare
radoering
force-pushed
the
fix_build_directories
branch
from
3155ce5
to
b964529
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Sep 10, 2023
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#8390
Resolves: python-poetry/poetry#6197
This should fix issues with files not getting included / the wrong file getting included due to build/lib* naming differences. I tested it against the repo egorchakov made and it seems to have resolved what they were seeing.
I looked at a few different ways to resolve this, and ultimately decided the best solution was to have poetry determine what build folder names should be used rather than letting distutils figure it out. I couldn't come up with a solution that used the name generated by distutils that didn't involve a lot of kludging or be fragile to any changes. I think it probably makes more sense for the poetry build system to determine where things get built anyway. Open to suggestions though!
It's possible that this will have merge conflicts with #633 since they're both modifying the same code, if so I can rebase after that's merged