-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intelhex hangs on using in
operator
#58
Labels
Comments
sveinse
added a commit
to sveinse/intelhex
that referenced
this issue
Jul 21, 2022
Looks good for me. Thanks. |
Please, create a pull request, so maintainer can easily merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In python, using the
in
operator is used to test for membership, thus it would be natural to expect that the following expression is valid to test if the given address is present in the hex. However it hangs of an unknown reason.This has a trivial fix by implementing
__contains__
. I have implemented a fix and a test for it in my fork: https://github.com/sveinse/intelhex. Please give notice if a PR is wanted for this. https://github.com/sveinse/intelhexmaster...sveinse:intelhex:master
The text was updated successfully, but these errors were encountered: