Make cachier() more abstract for using other cores #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References python-cachier#4 and references python-cachier#6
Now, the default is calculated dynamically to maintain previous behavior to default to pickle unless the ``mongetter`` argument is given. This makes it have the same behavior as before, so users aren't forced to change old code to use the ``backend`` argument
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 95.74% 95.85% +0.11%
==========================================
Files 4 4
Lines 329 338 +9
Branches 31 34 +3
==========================================
+ Hits 315 324 +9
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
|
@shaypal5 Thanks for the comment on the other thread. I just wanted to reiterate that this change doesn't break backwards compatibility and should be enough to enable at least the implementation of an in memory cache, which like the pickle one, can be instantiated without any extra kwargs. Thanks again for the consideration. |
|
This code was merged via #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
backendargument to thecachier()to allow users to explicitly set the core that is used. Right now, it does not include any new cores, but does give an example as to where potential codes supporting #4 and #6 could be added.Sidebar: it might be the case that later, it needs to be reinvestigated how arguments are passed to the core - if there are many cores, having all of their extra arguments inside the
cachier()function could get verbose. One way might be to use**kwargs, but I think it's worth waiting until other cores are implemented to worry about that abstractions.If you're happy with this PR, I would also like to take a stab at implementing #6.