-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TerminalRepr instances to be hashable #6988
Conversation
Reproduces: INTERNALERROR> TypeError: unhashable type: 'ExceptionChainRepr' Ref: pytest-dev#515 Ref: pytest-dev/pytest#6988
Reproduces: INTERNALERROR> TypeError: unhashable type: 'ExceptionChainRepr' Ref: pytest-dev#515 Ref: pytest-dev/pytest#6988
dbd10bc
to
6589586
Compare
c7d28e9
to
aad0980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been nice to set frozen=True
and use value-based equality/hashing, but I guess that's impractical (or even undesirable?)? So LGTM.
Hmm but again I see this is targeted at |
I would find it easier to just merge 5.4.x into master, instead of cherry-picking things to the release branch. I've looked quickly for docs, found nothing and thought this would be easier. |
aad0980
to
a1d0d7c
Compare
Yes we should document it somewhere, but the idea is that all new development is done on master and then backported as needed, without merging branches. |
Indeed, I understand that the main aspect of the change was for contributors to always target |
pytest-xdist assumes `ExceptionChainRepr` is hashable. Fixes pytest-dev#6925. Fixes pytest-dev/pytest-xdist#515.
a1d0d7c
to
043ecaa
Compare
Sure, I'm not saying they need to decide and that we should not do "backports" in general. |
pytest-xdist assumes `ExceptionChainRepr` is hashable. Fixes pytest-dev#6925. Fixes pytest-dev/pytest-xdist#515. (cherry picked from commit 20f6331)
Reproduces: INTERNALERROR> TypeError: unhashable type: 'ExceptionChainRepr' Ref: pytest-dev#515 Ref: pytest-dev/pytest#6988
Reproduces: INTERNALERROR> TypeError: unhashable type: 'ExceptionChainRepr' Ref: pytest-dev#515 Ref: pytest-dev/pytest#6988
pytest-xdist assumes `ExceptionChainRepr` is hashable. Fixes #6925. Fixes pytest-dev/pytest-xdist#515. (cherry picked from commit 20f6331)
pytest-xdist assumes `ExceptionChainRepr` is hashable. Fixes pytest-dev#6925. Fixes pytest-dev/pytest-xdist#515. (cherry picked from commit 20f6331) pytest-dev#6988 Conflicts: src/_pytest/_code/code.py testing/code/test_code.py
Reproduces: INTERNALERROR> TypeError: unhashable type: 'ExceptionChainRepr' Ref: pytest-dev#515 Ref: pytest-dev/pytest#6988
Reproduces: INTERNALERROR> TypeError: unhashable type: 'ExceptionChainRepr' Ref: pytest-dev#515 Ref: pytest-dev/pytest#6988
pytest-xdist assumes
ExceptionChainRepr
is hashable.Fixes #6925.
Fixes pytest-dev/pytest-xdist#515.