Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncated locals in verbose mode #3681

Merged

Conversation

tadeoos
Copy link
Contributor

@tadeoos tadeoos commented Jul 14, 2018

This PR aims at fixing #980.
I am not sure if this counts as trivial change or not -- I've updated the AUTHORS file but have no problem with removing myself from there in case this work is not sufficient :)

@coveralls
Copy link

coveralls commented Jul 14, 2018

Coverage Status

Coverage increased (+0.06%) to 92.535% when pulling d2fe619 on tadeoos:980-fix-truncated-locals-in-verbose into f6ceedd on pytest-dev:features.

@nicoddemus
Copy link
Member

I @tadeoos, thanks a lot for the contribution! Just need to rebase on the features branch as this is a new feature/behavior. 👍

@nicoddemus nicoddemus force-pushed the 980-fix-truncated-locals-in-verbose branch from 8757ee7 to d2fe619 Compare July 15, 2018 14:31
@nicoddemus nicoddemus changed the base branch from master to features July 15, 2018 14:31
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took the liberty of rebasing on features.

Thanks again @tadeoos!

@tadeoos
Copy link
Contributor Author

tadeoos commented Jul 15, 2018

Hey! I've just came back home (had a mate's weeding yesterday) to do the rebase and I saw the job is done :) Thanks for help and smooth collaboration @nicoddemus!

@tadeoos tadeoos deleted the 980-fix-truncated-locals-in-verbose branch July 15, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants