Don't mark empty doctest files as skipped, fixes #1578 #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really understand the implications of the change, but it seems like it made a lot of tests fail 😉 |
|
@The-Compiler yeah I know :p |
|
i think this is related to fixture support for docktests, @nicoddemus do you remember details by chance? |
graingert
force-pushed
the
fix-all-skipped-but-none-exist
branch
3 times, most recently
from
18a15c4
to
3aa6858
Compare
| items, reprec = testdir.inline_genitems(w) | ||
| assert len(items) == 1 |
There was a problem hiding this comment.
this looks like it was a test bug
graingert
force-pushed
the
fix-all-skipped-but-none-exist
branch
from
3aa6858
to
cd427a1
Compare
|
requires #1582 to pass |
graingert
force-pushed
the
fix-all-skipped-but-none-exist
branch
from
cd427a1
to
74862b8
Compare
|
Looks good, it makes much more sense for |
|
Only missing |
|
AppVeyor is slooooooww |
|
Yep, it doesn't have multiple jobs like Travis, so we wait. 😌 |
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jun 1, 2016
|
Merged, thanks again @graingert! (The AppVeyor failure was unrelated, will see to that in a separate PR) |
This was referenced Aug 19, 2016
This was referenced Nov 15, 2017
Merged
This was referenced Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.