-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve idmaker name selection in case of duplicate ids in parametrize #1474
Merged
nicoddemus
merged 4 commits into
pytest-dev:features
from
palaviv:improve-idmaker-duplicate-names
Mar 23, 2016
Merged
Improve idmaker name selection in case of duplicate ids in parametrize #1474
nicoddemus
merged 4 commits into
pytest-dev:features
from
palaviv:improve-idmaker-duplicate-names
Mar 23, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -26,7 +26,8 @@ | |||
* parametrize ids can accept None as specific test id. The | |||
automatically generated id for that argument will be used. | |||
|
|||
* | |||
* improved idmaker name selection in case of duplicate ids in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a "thanks palaviv" and mention #1474. You might want to do the same for the item just above this one. 😉
It seems that the travis-ci failed because of some error unrelated to the tests:
Is there a way to rerun the build? |
I just restarted the failing build. |
Thanks again @palaviv! 😄 |
This was referenced Aug 24, 2016
This was referenced Aug 31, 2016
This was referenced Nov 15, 2017
Merged
This was referenced Nov 27, 2017
This was referenced Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @RonnyPfannschmidt mentioned in pull request #1468 the name selection in case of duplicate ids had some problems.
Let's take for example:
Before this change the tests names would be:
After this change: