Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy error in errisinstance #12700

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Fix mypy error in errisinstance #12700

merged 5 commits into from
Aug 9, 2024

Conversation

reaganjlee
Copy link
Contributor

Fixes #12667

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Aug 9, 2024
@nicoddemus
Copy link
Member

Thanks!

@nicoddemus nicoddemus added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label Aug 9, 2024
@nicoddemus nicoddemus merged commit cb98538 into pytest-dev:main Aug 9, 2024
29 checks passed
@patchback Patchback
Copy link

patchback bot commented Aug 9, 2024 •
edited
Loading

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/cb98538e9c2ba3c65baf07432229d97fd5a29657/pr-12700

Backported as #12704

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 9, 2024
@reaganjlee @patchback
Fix errisinstance typing (#12700)
a70c8e6 
Fixes #12667

(cherry picked from commit cb98538)
@patchback patchback bot mentioned this pull request Aug 9, 2024
Merged
nicoddemus pushed a commit that referenced this pull request Aug 9, 2024
@patchback @reaganjlee
Fix errisinstance typing (#12700) (#12704)
8fb7fae 
Fixes #12667

(cherry picked from commit cb98538)

Co-authored-by: Reagan Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too tight a type constraint on ExceptionInfo.errisinstance
2 participants
@reaganjlee @nicoddemus