Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.1 section missing from changelog #3538

Closed
edmorley opened this issue Jun 5, 2018 · 3 comments
Closed

3.6.1 section missing from changelog #3538

edmorley opened this issue Jun 5, 2018 · 3 comments
Labels
type: docs documentation improvement, missing or needing clarification

Comments

@edmorley
Copy link

edmorley commented Jun 5, 2018

Hi!

There is no v3.6.1 section in the changelog:
https://docs.pytest.org/en/latest/changelog.html
https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst

...which means that PRs opened by pyup are missing the release notes, eg:
mozilla/treeherder#3614

Would it be possible to ensure the changelog entries are present before publishing? (Since even if they are added after, it's too late for the PRs that have already been auto-generated).

Many thanks :-)

@pytestbot pytestbot added the type: docs documentation improvement, missing or needing clarification label Jun 5, 2018
@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #3536 (3.6.1 fails on "setup.py test"), #1275 (Separate issues in the CHANGELOG into sections), #1627 (Drop Python 3.0/3.1/3.2/2.6?), #2485 (max recursion depth in 3.1.2), and #722 (Missing tag for xdist release 1.11).

@nicoddemus
Copy link
Member

Thanks @edmorley for reporting.

What happened is that we took a little longer to merge than usual. I started the process at night by opening the PR, and merged early in the morning by pushing the tag, but got busy with other things and only merged the PR itself several hours later.

Would it be possible to ensure the changelog entries are present before publishing? (Since even if they are added after, it's too late for the PRs that have already been auto-generated).

With the current process no, because the package is published from the PR... but we will try to reduce the gap between publishing and merging as much as possible in the future.

Thanks again! 👍

@edmorley
Copy link
Author

edmorley commented Jun 6, 2018

Many thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

No branches or pull requests

3 participants