Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node and link water quality features #206

Closed
katmratliff opened this issue Aug 19, 2019 · 5 comments · Fixed by #217
Closed

Node and link water quality features #206

katmratliff opened this issue Aug 19, 2019 · 5 comments · Fixed by #217

Comments

@katmratliff
Copy link
Contributor

katmratliff commented Aug 19, 2019

Build out the node and link access to pollutant/water quality values. I am actively working on this.

@katmratliff katmratliff self-assigned this Aug 19, 2019
@katmratliff katmratliff changed the title Node and link water quality API Node and link water quality features Aug 19, 2019
@bemcdonnell
Copy link
Member

@katmratliff, how is this going? Should we try to couple this into a new pyswmm release?

@katmratliff
Copy link
Contributor Author

katmratliff commented Oct 19, 2019

@bemcdonnell that sounds great. I've got the code working and ready to go in my branch, just need to add some tests. I was waiting to submit a PR until this SWMM PR was merged. Also, how are you and @jennwuu building the x64 binaries?

@jennwuu
Copy link
Contributor

jennwuu commented Oct 21, 2019

@katmratliff the x64 and x32 binaries for mac and linux are uploaded under draft release for successful build on the develop branch. The x64 and x32 binaries for windows are under artifacts on appveyor.

@katmratliff
Copy link
Contributor Author

@jennwuu cool, as in I don't need to compile them locally? I'll just need to pull out what gets built and stick them in my pyswmm branch?

@jennwuu
Copy link
Contributor

jennwuu commented Oct 21, 2019

@katmratliff exactly! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants