Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storm 1.0.3+ Mulitlang resource path support, (#362) #366

Merged
merged 3 commits into from
May 17, 2017

Conversation

rwatler
Copy link
Contributor

@rwatler rwatler commented Apr 28, 2017

Add 'resource' path to load spout/bolt components in streamparse_run for Storm 1.0.3.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 44.403% when pulling 80a6b76 on rwatler:issue-362 into 3be6c85 on Parsely:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 45.735% when pulling 5c320cd on rwatler:issue-362 into 3be6c85 on Parsely:master.

# patch streamparse_run sys argv assuming tests run
# from streamparse project root, (Storm <= 1.0.2 case)
sys.argv = ['streamparse_run',
'test.'
Copy link
Member

@dan-blanchard dan-blanchard May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how things would still work with this extra 'test.' argument in sys.argv. argparse isn't going to know what to do with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not an extra argument, (no comma following the 'test.' string). The two strings are appended into a long string. Long string was split to place emphasis on the added 'test.' path required to reach the target bolt, (simulates the extra 'resources' folder in path for Storm <= 1.0.2). There is another split on the 2nd test case below. There the --serializer option is concatenated to the argument.

Let me know if you want me to make this more clear by pulling these together into one string. :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd prefer just having the string all on one line, or doing:

sys.argv = ['streamparse_run',
            ('test.'
             'streamparse_run.streamparse_run_target.StreamparseRunTarget')]

to make it more obvious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 3c5d005

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 47.869% when pulling 3c5d005 on rwatler:issue-362 into 3be6c85 on Parsely:master.

@dan-blanchard dan-blanchard merged commit 9729394 into pystorm:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants