Maint work for update supported Python versions, CI environments, et.c #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 27 27
Lines 2636 2636
=====================================
Hits 2048 2048
Misses 588 588
|
martinfleis
approved these changes
Dec 3, 2023
| @@ -6,7 +6,6 @@ dependencies: | |||
| - geopandas | |||
| - libpysal | |||
| - mapclassify | |||
| - matplotlib | |||
There was a problem hiding this comment.
Don't know the reason of removal. Just a not that this will come with geopandas anyway.
There was a problem hiding this comment.
Reason for removal is like you said, matplotlib comes from geoapndas anyway and it is not a core dependency of spopt.
jGaboardi
added a commit
to jGaboardi/spopt
that referenced
this pull request
Dec 4, 2023
jGaboardi
added a commit
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #412