Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requirements_notebooks.txt to MANIFEST #344

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add requirements_notebooks.txt to MANIFEST #344

merged 1 commit into from
Jan 13, 2023

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jan 13, 2023 •
edited

@jGaboardi jGaboardi self-assigned this Jan 13, 2023
@martinfleis
Copy link
Member

not a huge fan of this solution of loading all reps from n files on setup (pyproject.toml would be certainly better) but it is fine now.

long-term, none of these should be in manifest as they're not needed in the wheel.

@jGaboardi
Copy link
Member Author

not a huge fan of this solution of loading all reps from n files on setup (pyproject.toml would be certainly better) but it is fine now.

long-term, none of these should be in manifest as they're not needed in the wheel.

FWIW, I agree. After we work the kinks out of using pyproject.toml exclusively (it's causing a headache over in spaghetti) then I'll start pushing for adoption across the PySAL ecosystem.

@martinfleis martinfleis merged commit 761e2c1 into pysal:main Jan 13, 2023
@jGaboardi jGaboardi deleted the update_manifest branch January 13, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knaaptime knaaptime Awaiting requested review from knaaptime

@martinfleis martinfleis Awaiting requested review from martinfleis

Assignees

@jGaboardi jGaboardi

Labels
conda-forge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The requirementes notebook is missing from the MANIFEST.in
2 participants
@jGaboardi @martinfleis