Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: check loops in remove_false_nodes against any node degree #647

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

martinfleis
Copy link
Member

No description provided.

@jGaboardi jGaboardi added the bug Something isn't working label Jul 18, 2024
@martinfleis
Copy link
Member Author

@jGaboardi if you want to ask about tests, I really don't want to do them :D

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.0%. Comparing base (4037c70) to head (ee7bd76).
Report is 77 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #647     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.7%     
=======================================
  Files         26      38     +12     
  Lines       4328    6278   +1950     
=======================================
+ Hits        4214    6155   +1941     
- Misses       114     123      +9     
Files Coverage Δ
momepy/preprocessing.py 91.9% <100.0%> (-1.4%) ⬇️

@jGaboardi
Copy link
Member

Do we not need a test for this? Or is the test implicit?

@jGaboardi
Copy link
Member

@jGaboardi if you want to ask about tests, I really don't want to do them :D

perfect timing -- we commented at exactly the same time

@martinfleis
Copy link
Member Author

It is not implicit but given how tests for this are structured now, we would need to alter the test data. Just pretend you missed the missing tests :D

@martinfleis martinfleis merged commit 85d5930 into pysal:main Jul 18, 2024
14 of 15 checks passed
@martinfleis martinfleis deleted the node2-fix branch July 18, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants